Kikkon commented on code in PR #5493:
URL: https://github.com/apache/arrow-rs/pull/5493#discussion_r1519231542
##########
arrow-data/src/data.rs:
##########
@@ -119,12 +119,22 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity:
usize) -> [MutableBuff
buffer.push(0i32);
[buffer, empty_buffer]
}
+ DataType::ListView(_) => {
+ let mut buffer = MutableBuffer::new((1 + capacity) *
mem::size_of::<i64>());
+ buffer.push(0i32);
Review Comment:
You are right, I will fix this later.(：Originally, I planned to implement
the method in the next pull request, so I overlooked this for now.
##########
arrow-data/src/data.rs:
##########
@@ -119,12 +119,22 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity:
usize) -> [MutableBuff
buffer.push(0i32);
[buffer, empty_buffer]
}
+ DataType::ListView(_) => {
+ let mut buffer = MutableBuffer::new((1 + capacity) *
mem::size_of::<i64>());
+ buffer.push(0i32);
Review Comment:
You are right, I will fix this later. (：Originally, I planned to implement
the method in the next pull request, so I overlooked this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
