alamb commented on code in PR #5493:
URL: https://github.com/apache/arrow-rs/pull/5493#discussion_r1521304785
##########
arrow-schema/src/datatype.rs:
##########
@@ -228,12 +228,30 @@ pub enum DataType {
///
/// A single List array can store up to [`i32::MAX`] elements in total.
List(FieldRef),
+
+ /// (NOT YET FULLY SUPPORTED) A list of some logical data type with
variable length.
+ ///
+ /// Note this data type is not yet fully supported. Using it with arrow
APIs may result in `panic`s.
+ ///
+ /// The ListView layout is defined by three buffers:
+ /// a validity bitmap, an offsets buffer, and an additional sizes buffer.
+ /// Sizes and offsets have the identical bit width and both 32-bit signed
integer options is supported.
Review Comment:
```suggestion
/// Sizes and offsets are both 32 bits for this type
```
##########
arrow-schema/src/datatype.rs:
##########
@@ -228,12 +228,30 @@ pub enum DataType {
///
/// A single List array can store up to [`i32::MAX`] elements in total.
List(FieldRef),
+
+ /// (NOT YET FULLY SUPPORTED) A list of some logical data type with
variable length.
+ ///
+ /// Note this data type is not yet fully supported. Using it with arrow
APIs may result in `panic`s.
+ ///
+ /// The ListView layout is defined by three buffers:
+ /// a validity bitmap, an offsets buffer, and an additional sizes buffer.
+ /// Sizes and offsets have the identical bit width and both 32-bit signed
integer options is supported.
+ ListView(FieldRef),
/// A list of some logical data type with fixed length.
FixedSizeList(FieldRef, i32),
/// A list of some logical data type with variable length and 64-bit
offsets.
///
/// A single LargeList array can store up to [`i64::MAX`] elements in
total.
LargeList(FieldRef),
+
+ /// (NOT YET FULLY SUPPORTED) A list of some logical data type with
variable length and 64-bit offsets.
+ ///
+ /// Note this data type is not yet fully supported. Using it with arrow
APIs may result in `panic`s.
+ ///
+ /// The LargeListView layout is defined by three buffers:
+ /// a validity bitmap, an offsets buffer, and an additional sizes buffer.
+ /// Sizes and offsets have the identical bit width and both 64-bit signed
integer options is supported.
Review Comment:
```suggestion
/// Sizes and offsets are both 64 bits for this type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
