backkem commented on issue #8661:
URL: 
https://github.com/apache/arrow-datafusion/issues/8661#issuecomment-1991214458

   Does it make sense for me to lay the same 'groundwork' for the `Plan` 
serialization as I did for the `Expr` in #9517?
   The suggestion would be similar: Upstream the datafusion-federation 
sql-write code as follows:
   * Upstream the [AST 
builders](https://github.com/datafusion-contrib/datafusion-federation/blob/35459193fd66c4476fceae65df5f3163242789c7/sql-writer/src/ast_builder.rs)
 to sqlparser-rs.
   * Upstream the plan 
[unparser](https://github.com/datafusion-contrib/datafusion-federation/blob/35459193fd66c4476fceae65df5f3163242789c7/sql-writer/src/lib.rs)
 to `datafusion/sql/src/unparser`.
     * Expose a `plan_to_sql` method similar to `expr_to_sql`.
   
   Any early thoughts or feedback on the datafusion-federation code sql-write 
code is appreciated, so I can address it in the process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to