alamb commented on issue #8661: URL: https://github.com/apache/arrow-datafusion/issues/8661#issuecomment-1992780445
> Does it make sense for me to lay the same 'groundwork' for the `LogicalPlan` serialization as I did for the `Expr` in #9517? I agree with @devinjdangelo that I think it does. > If the AST builder functionality is not particularly useful in `sqlparser`, it is likely best to include that in datafusion only rather than upstream to `sqlparser`. Do you think the AST builders would be useful upstream @alamb? I am not sure, to be honest. I think if we upstreamed a AST builder style thing in sqlparser, we would also want to migrate the existing parser to use it (and therefore take advantage of the existing tests). I think as long as it were backwards compatible it would make a nice contribution. However, I would also say there is no compelling need to upstream it either. Having it start life in DataFusion would also be fine and then maybe upstream it in sqlparser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
