lidavidm commented on code in PR #40436:
URL: https://github.com/apache/arrow/pull/40436#discussion_r1521574717
##########
java/vector/src/main/java/org/apache/arrow/vector/NullVector.java:
##########
@@ -73,17 +74,19 @@ public NullVector(String name, int valueCount) {
* @param name name of the vector
* @param fieldType type of Field materialized by this vector.
*/
+ @Deprecated
public NullVector(String name, FieldType fieldType) {
- this(new Field(name, fieldType, null));
+ this(name);
}
/**
* Instantiate a NullVector.
*
* @param field field materialized by this vector.
*/
+ @Deprecated
public NullVector(Field field) {
Review Comment:
I think to allow generic code it might be best to still allow the various
field constructors, and just check that the field type is actually NULL, using
https://github.com/apache/arrow/blob/0ce72675f4dd755b2696eb6597850b21df647bb8/java/memory/memory-core/src/main/java/org/apache/arrow/util/Preconditions.java#L130-L144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
