lidavidm commented on code in PR #40436:
URL: https://github.com/apache/arrow/pull/40436#discussion_r1526370643
##########
java/vector/src/main/java/org/apache/arrow/vector/NullVector.java:
##########
@@ -73,17 +74,19 @@ public NullVector(String name, int valueCount) {
* @param name name of the vector
* @param fieldType type of Field materialized by this vector.
*/
+ @Deprecated
public NullVector(String name, FieldType fieldType) {
- this(new Field(name, fieldType, null));
+ this(name);
}
/**
* Instantiate a NullVector.
*
* @param field field materialized by this vector.
*/
+ @Deprecated
public NullVector(Field field) {
Review Comment:
Mostly so code that already has a field doesn't have to special case
NullVector vs other vectors, and to keep the various vectors somewhat
consistent.
e.g. IntVector has these constructors too (arguably, it should also be
validating the type!)
https://github.com/apache/arrow/blob/0402e306a9d9f57ff22c87bf8689b8e7203483e5/java/vector/src/main/java/org/apache/arrow/vector/IntVector.java#L48-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
