sunchao commented on code in PR #197:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/197#discussion_r1522565839
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -186,6 +186,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
}
}
+ private def bitwiseAggTypeSupported(dt: DataType): Boolean = {
+ dt match {
+ case _: IntegerType => true
Review Comment:
I think Spark supports all `Integral` type as input type which includes
other types such as long and short. Maybe we can add them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
