huaxingao commented on code in PR #197:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/197#discussion_r1523981859
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -186,6 +186,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
}
}
+ private def bitwiseAggTypeSupported(dt: DataType): Boolean = {
+ dt match {
+ case _: IntegerType | LongType | ShortType | ByteType => true
+ case _ => false
+ }
+ }
Review Comment:
Spark bitwise aggregates only supports `INTEGRAL` type. If I try other
types, Spark throws Exception:
```
Cannot resolve "bit_and(col1)" due to data type mismatch: Parameter 1
requires the "INTEGRAL" type, however "col1" has the type ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
