bkietz commented on a change in pull request #9294: URL: https://github.com/apache/arrow/pull/9294#discussion_r571184083
########## File path: cpp/src/arrow/compute/kernels/common.h ########## @@ -51,4 +51,16 @@ namespace arrow { using internal::checked_cast; using internal::checked_pointer_cast; +namespace compute { +namespace detail { + +/// \brief Look up a kernel in a function. If no Kernel is found, nullptr is returned. +ARROW_EXPORT +const Kernel* DispatchExactImpl(const Function* func, const std::vector<ValueDescr>&); + +ARROW_EXPORT +Status NoMatchingKernel(const Function* func, const std::vector<ValueDescr>&); Review comment: These are defined in `function.cc`. I'll move the declarations to `function.h` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org