devinjdangelo commented on code in PR #9606:
URL: https://github.com/apache/arrow-datafusion/pull/9606#discussion_r1524895969


##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -176,7 +250,9 @@ impl Unparser<'_> {
                 )
             }
             LogicalPlan::Aggregate(_agg) => {

Review Comment:
   I'm currently assuming all aggregate plan nodes are preceded by a projection 
plan node. These two nodes are then handled together simultaneously in the 
above projection node block. 
   
   @alamb I was wondering if you know:
   
   1. If an Aggregate plan node can ever NOT be preceded by a projection plan 
node?
   2. If so, under what circumstances and what does that mean intuitively?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to