backkem commented on code in PR #9606:
URL: https://github.com/apache/arrow-datafusion/pull/9606#discussion_r1525021697
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -176,7 +250,9 @@ impl Unparser<'_> {
)
}
LogicalPlan::Aggregate(_agg) => {
Review Comment:
This does indeed become more tricky. I guess the schema computed at every
layer of the plan passes up enough information for execution but maybe not for
our Unparser use-case. The specific columns being selected are no longer
needed/known at the aggregation step.
I wonder if it's worth creating a structure next to the plan that builds up
schema-like data for serialization purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
