kou commented on code in PR #40578:
URL: https://github.com/apache/arrow/pull/40578#discussion_r1526508211
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -968,6 +968,8 @@ if(NOT ARROW_BUILD_SHARED AND ARROW_BUILD_STATIC)
string(APPEND ARROW_TESTING_PC_CFLAGS "${ARROW_TESTING_PC_CFLAGS_PRIVATE}")
set(ARROW_TESTING_PC_CFLAGS_PRIVATE "")
+
+ string(APPEND ARROW_PC_LIBS_PRIVATE " -l${CMAKE_DL_LIBS}")
Review Comment:
If we build Apache Arrow C++ for single propose (e.g. creating a PyArrow
wheel), we don't need to build shared and static libraries. But if we want to
use multiple proposes (e.g. using it from Python and R), we may need shared and
static libraries.
Most packaging systems (deb, rpm and so on) provide both of shared and
static libraries to support multiple proposes. If Apache Arrow C++ supports
building both shared and static library, they don't need to build Apache Arrow
C++ twice to build shared and static libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
