bkietz commented on code in PR #40578:
URL: https://github.com/apache/arrow/pull/40578#discussion_r1526636738
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -968,6 +968,8 @@ if(NOT ARROW_BUILD_SHARED AND ARROW_BUILD_STATIC)
string(APPEND ARROW_TESTING_PC_CFLAGS "${ARROW_TESTING_PC_CFLAGS_PRIVATE}")
set(ARROW_TESTING_PC_CFLAGS_PRIVATE "")
+
+ string(APPEND ARROW_PC_LIBS_PRIVATE " -l${CMAKE_DL_LIBS}")
Review Comment:
> If Apache Arrow C++ supports building both shared and static library, they
don't need to build Apache Arrow C++ twice
I think you'd only be able to reuse the object files, which should be doable
by having adjacent build directories both using ccache. We can't even reuse
object files on WIN32 because we add `-DARROW_STATIC` there and so the object
files linked into `arrow_static` are different from those linked into
`arrow_shared`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
