alamb commented on code in PR #9604:
URL: https://github.com/apache/arrow-datafusion/pull/9604#discussion_r1526815993
##########
datafusion/sqllogictest/test_files/copy.slt:
##########
@@ -111,49 +111,52 @@ a
statement ok
create table test ("'test'" varchar, "'test2'" varchar, "'test3'" varchar);
-query TTT
-insert into test VALUES ('a', 'x', 'aa'), ('b','y', 'bb'), ('c', 'z', 'cc')
-----
-3
-
-query T
-select "'test'" from test
-----
-a
-b
-c
-
-# Note to place a single ' inside of a literal string escape by putting two ''
-query TTT
-copy test to 'test_files/scratch/copy/escape_quote' (format csv, partition_by
'''test2'',''test3''')
-----
-3
-
-statement ok
-CREATE EXTERNAL TABLE validate_partitioned_escape_quote STORED AS CSV
-LOCATION 'test_files/scratch/copy/escape_quote/' PARTITIONED BY ("'test2'",
"'test3'");
-
+## Until the partition by parsing uses ColumnDef, this test is meaningless
since it becomes an overfit. Even in
Review Comment:
Here is the expalanation of why this test is commented out:
https://github.com/synnada-ai/datafusion-upstream/pull/10#discussion_r1526407025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
