alamb commented on code in PR #9604: URL: https://github.com/apache/arrow-datafusion/pull/9604#discussion_r1526399541
########## datafusion/sqllogictest/test_files/clickbench.slt: ########## @@ -23,7 +23,7 @@ # create.sql came from # https://github.com/ClickHouse/ClickBench/blob/8b9e3aa05ea18afa427f14909ddc678b8ef0d5e6/datafusion/create.sql # Data file made with DuckDB: -# COPY (SELECT * FROM 'hits.parquet' LIMIT 10) TO 'clickbench_hits_10.parquet' (FORMAT PARQUET); +# COPY (SELECT * FROM 'hits.parquet' LIMIT 10) TO 'clickbench_hits_10.parquet' STORED AS PARQUET; Review Comment: I agree that supporting the duckdb style would be nice, but that this PR's consistency is also nice I wonder if it would be possible (as a follow on PR) to add some special case backwards compatibility code to support the `(FORMAT PARQUET)` style? It seems to me like this could be a small amount of additional, localized code, and then we could going forward use the unified approach in this PR by default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
