viirya commented on code in PR #213:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/213#discussion_r1527654024
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -368,15 +367,24 @@ class CometSparkSessionExtensions
u
}
- case b: BroadcastExchangeExec
- if isCometNative(b.child) && isCometOperatorEnabled(conf,
"broadcastExchangeExec") &&
- isCometBroadCastEnabled(conf) =>
- QueryPlanSerde.operator2Proto(b) match {
- case Some(nativeOp) =>
- val cometOp = CometBroadcastExchangeExec(b, b.child)
- CometSinkPlaceHolder(nativeOp, b, cometOp)
- case None => b
+ // `CometBroadcastExchangeExec`'s broadcast output is not compatible
with Spark's broadcast
+ // exchange. It is only used for Comet native execution.
+ case plan
+ if isCometNative(plan) &&
+ plan.children.exists(_.isInstanceOf[BroadcastExchangeExec]) =>
+ val newChildren = plan.children.map {
+ case b: BroadcastExchangeExec
+ if isCometNative(b.child) &&
+ isCometOperatorEnabled(conf, "broadcastExchangeExec") =>
Review Comment:
Using the common operator enable config to control broadcast operator as
other operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
