viirya commented on code in PR #213:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/213#discussion_r1527654143
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -547,11 +555,9 @@ object CometSparkSessionExtensions extends Logging {
private[comet] def isCometOperatorEnabled(conf: SQLConf, operator: String):
Boolean = {
val operatorFlag = s"$COMET_EXEC_CONFIG_PREFIX.$operator.enabled"
- conf.getConfString(operatorFlag, "false").toBoolean ||
isCometAllOperatorEnabled(conf)
- }
-
- private[comet] def isCometBroadCastEnabled(conf: SQLConf): Boolean = {
- COMET_EXEC_BROADCAST_ENABLED.get(conf)
+ val operatorDisabledFlag = s"$COMET_EXEC_CONFIG_PREFIX.$operator.disabled"
+ conf.getConfString(operatorFlag, "false").toBoolean ||
isCometAllOperatorEnabled(conf) &&
+ !conf.getConfString(operatorDisabledFlag, "false").toBoolean
Review Comment:
This is added to be able disable certain operator specially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
