viirya commented on code in PR #178:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/178#discussion_r1527669296
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1838,6 +1840,62 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
}
}
+ case join: SortMergeJoinExec if isCometOperatorEnabled(op.conf,
"sort_merge_join") =>
+ // `requiredOrders` and `getKeyOrdering` are copied from Spark's
SortMergeJoinExec.
+ def requiredOrders(keys: Seq[Expression]): Seq[SortOrder] = {
+ keys.map(SortOrder(_, Ascending))
+ }
+
+ def getKeyOrdering(
Review Comment:
`outputOrdering` is not exactly same as the key ordering here. The key
ordering only counts in left keys ordering. But `outputOrdering`, for example,
is empty for full join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
