jayzhan211 commented on code in PR #9595:
URL: https://github.com/apache/arrow-datafusion/pull/9595#discussion_r1528443799
##########
datafusion/common/src/column.rs:
##########
@@ -355,36 +349,25 @@ impl fmt::Display for Column {
#[cfg(test)]
mod tests {
use super::*;
- use crate::DFField;
use arrow::datatypes::DataType;
- use std::collections::HashMap;
-
- fn create_schema(names: &[(Option<&str>, &str)]) -> Result<DFSchema> {
- let fields = names
- .iter()
- .map(|(qualifier, name)| {
- DFField::new(
- qualifier.to_owned().map(|s| s.to_string()),
- name,
- DataType::Boolean,
- true,
- )
- })
- .collect::<Vec<_>>();
- DFSchema::new_with_metadata(fields, HashMap::new())
+ use arrow_schema::{Field, SchemaBuilder};
+
+ fn create_qualified_schema(qualifier: &str, names: &[&str]) ->
Result<DFSchema> {
Review Comment:
I think names: Vec<String> is much simpler
##########
datafusion/common/src/column.rs:
##########
@@ -355,36 +349,25 @@ impl fmt::Display for Column {
#[cfg(test)]
mod tests {
use super::*;
- use crate::DFField;
use arrow::datatypes::DataType;
- use std::collections::HashMap;
-
- fn create_schema(names: &[(Option<&str>, &str)]) -> Result<DFSchema> {
- let fields = names
- .iter()
- .map(|(qualifier, name)| {
- DFField::new(
- qualifier.to_owned().map(|s| s.to_string()),
- name,
- DataType::Boolean,
- true,
- )
- })
- .collect::<Vec<_>>();
- DFSchema::new_with_metadata(fields, HashMap::new())
+ use arrow_schema::{Field, SchemaBuilder};
+
+ fn create_qualified_schema(qualifier: &str, names: &[&str]) ->
Result<DFSchema> {
Review Comment:
I think `names: Vec<String>` is much simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
