jayzhan211 commented on PR #9595:
URL:
https://github.com/apache/arrow-datafusion/pull/9595#issuecomment-2006461423
> > @haohuaijin I see that `Option<OwnedTableRefence>` and `Field` are
tuples in many places, is there any reason not to have DFField wrapping these
two values?
>
> There is no reason not to do this, but we should change the DFField type,
like below, because we return &, not the actual value.
>
> ```rust
> struct DFField<'a> {
> qualifier: Option<&'a OwnedTableReference>,
> field: &'a Field,
> }
> ```
>
> or
>
> ```rust
> type DFField = (Option<&'a OwnedTableReference>, &'a Field);
> ```
>
> what do you think about it?
what is the reason to return with reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
