tinfoil-knight commented on code in PR #9689:
URL: https://github.com/apache/arrow-datafusion/pull/9689#discussion_r1530089628
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -171,7 +171,11 @@ fn _to_char_scalar(
// of the implementation in arrow-rs we need to convert it to an array
let data_type = &expression.data_type();
let is_scalar_expression = matches!(&expression, ColumnarValue::Scalar(_));
- let array = expression.into_array(1)?;
+ let array_from_expr = expression.into_array(1)?;
Review Comment:
Note for Reviewer:
We can't directly return null when we see that the format is `None` because
`format_options` (passed to `ArrayFormatter::try_new`) allow specifying the
string to show for null & we need to respect this configuration option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
