Omega359 commented on PR #9689: URL: https://github.com/apache/arrow-datafusion/pull/9689#issuecomment-2008472924
The only additions I have beyond what @alamb covered is that we probably want to update the comment in invoke ``` // null format, use default formats ``` Since that wouldn't be true anymore. In addition it would be nice to have the tests in to_char.rs updated to include a test that passes in None for the format and expecting a None result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
