alamb commented on code in PR #9683:
URL: https://github.com/apache/arrow-datafusion/pull/9683#discussion_r1530447934
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -500,6 +508,14 @@ impl PartialOrd for ScalarValue {
(DurationMicrosecond(_), _) => None,
(DurationNanosecond(v1), DurationNanosecond(v2)) =>
v1.partial_cmp(v2),
(DurationNanosecond(_), _) => None,
+ (Union(v1, t1, _m1), Union(v2, t2, _m2)) => {
Review Comment:
won't this mean that dense unions are compared the same as sparse unions? It
seems like we should also compare `m1` and `m2`
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -275,6 +277,8 @@ pub enum ScalarValue {
DurationMicrosecond(Option<i64>),
/// Duration in nanoseconds
DurationNanosecond(Option<i64>),
+ /// A nested datatype that can represent slots of differing types.
Components:
Review Comment:
The `"Components: " seem` to be cut off in mid-sentence. Perhaps we could
document what each of the 4 fields represents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
