avantgardnerio commented on code in PR #9683:
URL: https://github.com/apache/arrow-datafusion/pull/9683#discussion_r1530690604


##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -500,6 +508,14 @@ impl PartialOrd for ScalarValue {
             (DurationMicrosecond(_), _) => None,
             (DurationNanosecond(v1), DurationNanosecond(v2)) => 
v1.partial_cmp(v2),
             (DurationNanosecond(_), _) => None,
+            (Union(v1, t1, _m1), Union(v2, t2, _m2)) => {

Review Comment:
   My thought was that if the unions have the same logical data, the physical 
way they choose to store it is irrelevant to their logical comparison.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to