paleolimbot commented on PR #1603: URL: https://github.com/apache/arrow-adbc/pull/1603#issuecomment-2007964380
I took a scan through these changes...there are a lot of them! The R changes look good...I can/will make them more resilient to changes in the C++ dependency (I promise that it is still easier than trying to locate CMake on everybody's Linux distribution). A few questions about the C++ changes: - Is the intention to add tests for the driver framework at some point? - I appreciate that the advanced templating and metaprogramming allows for more compact syntax for those who know how to use it; however, I wonder if we are excluding any potential contributors by invoking some of these concepts. I am almost certainly just projecting my own feelings about this (e.g., I feel unqualified to review this but want to help). - Do we need another error handling pattern? There is already nanoarrow + AdbcError + whatever C-based thing the driver is using. I can see how it would be helpful in a client helper library and if it's truly needed that's OK...it mostly just read to me as out of place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
