lidavidm commented on PR #1603: URL: https://github.com/apache/arrow-adbc/pull/1603#issuecomment-2007982286
- Tests at some point, yes (there's a TODO); but I want to make sure the structure is acceptable - CRTP is a fairly common template pattern. Virtual calls probably aren't a big deal, though. - I could see the argument to stick with AdbcError but then I question what Error in the original framework was for -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
