tustvold commented on code in PR #9648:
URL: https://github.com/apache/arrow-datafusion/pull/9648#discussion_r1531122052
##########
datafusion/core/src/datasource/file_format/write/mod.rs:
##########
@@ -69,79 +66,6 @@ impl Write for SharedBuffer {
}
}
-/// Stores data needed during abortion of MultiPart writers
Review Comment:
Local file system automatically cleans up on drop, or at least makes a best
effort to do so. FWIW this same mechanism is used for ALL uploads, even the
non-multipart ones so as to provide atomicity. Given nobody has complained
about this, I suspect it is doing a fairly good job
I am not aware of a cloud provider that provides multipart uploads without
some automated way to reap aborted uploads after a given time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
