pitrou commented on a change in pull request #9444:
URL: https://github.com/apache/arrow/pull/9444#discussion_r572916439
##########
File path: cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc
##########
@@ -32,10 +32,10 @@ constexpr auto kSeed = 0x94378165;
static void SetLookupBenchmarkString(benchmark::State& state,
const std::string& func_name,
const int64_t value_set_length) {
- const int64_t array_length = 1 << 20;
- const int64_t value_min_size = 0;
- const int64_t value_max_size = 32;
- const double null_probability = 0.01;
+ const int64_t array_length = 1 << 18;
+ const int32_t value_min_size = (value_set_length < 64) ? 2 : 10;
+ const int32_t value_max_size = 32;
+ const double null_probability = 0.2 / value_set_length;
Review comment:
Will do. The underlying concern is to avoid duplicates in the value_set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
