pitrou commented on a change in pull request #9444:
URL: https://github.com/apache/arrow/pull/9444#discussion_r572924215
##########
File path: cpp/src/arrow/util/bit_block_counter.h
##########
@@ -292,9 +413,10 @@ class ARROW_EXPORT OptionalBinaryBitBlockCounter {
// Functional-style bit block visitors.
template <typename VisitNotNull, typename VisitNull>
-Status VisitBitBlocks(const std::shared_ptr<Buffer>& bitmap_buf, int64_t
offset,
- int64_t length, VisitNotNull&& visit_not_null,
- VisitNull&& visit_null) {
+static inline Status VisitBitBlocks(const std::shared_ptr<Buffer>& bitmap_buf,
Review comment:
Ah, my bad. What about `static`, do you think it is useful?
(my thought: it doesn't expose the generated specializations as global
symbols)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
