pitrou commented on code in PR #39807:
URL: https://github.com/apache/arrow/pull/39807#discussion_r1532030312
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -284,8 +308,12 @@ class CompressedInputStream::Impl {
int64_t decompress_size = kDecompressSize;
while (true) {
- ARROW_ASSIGN_OR_RAISE(decompressed_,
- AllocateResizableBuffer(decompress_size, pool_));
+ if (decompressed_ == nullptr) {
+ ARROW_ASSIGN_OR_RAISE(decompressed_,
+ AllocateResizableBuffer(decompress_size, pool_));
+ } else {
+ RETURN_NOT_OK(decompressed_->Resize(decompress_size,
/*shrink_to_fit=*/false));
Review Comment:
Reallocating like this will need to copy the existing data, but we don't
need the data. It is not obvious it is faster than allocating a new buffer, it
probably depends on the underlying allocator.
@felipecrv Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
