mapleFU commented on code in PR #39807:
URL: https://github.com/apache/arrow/pull/39807#discussion_r1532165305
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -284,8 +308,12 @@ class CompressedInputStream::Impl {
int64_t decompress_size = kDecompressSize;
while (true) {
- ARROW_ASSIGN_OR_RAISE(decompressed_,
- AllocateResizableBuffer(decompress_size, pool_));
+ if (decompressed_ == nullptr) {
+ ARROW_ASSIGN_OR_RAISE(decompressed_,
+ AllocateResizableBuffer(decompress_size, pool_));
+ } else {
+ RETURN_NOT_OK(decompressed_->Resize(decompress_size,
/*shrink_to_fit=*/false));
Review Comment:
Sorry I wrote this a few days ago, I made it wrong. Applogize for this.
`decompressed_` would `Resize` when final output, which could make it smaller.
This edit to `decompressed_` might not bring optimization except for some weird
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
