vibhatha commented on code in PR #40520:
URL: https://github.com/apache/arrow/pull/40520#discussion_r1532173922
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +64,57 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _just_symbols(self, symbol_info):
+ return [line.split(' ')[-1] for line in symbol_info if line]
Review Comment:
@kou can we do better here?
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +64,57 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _just_symbols(self, symbol_info):
+ return [line.split(' ')[-1] for line in symbol_info if line]
+
+ def _no_weak(self, lines):
+ return [line for line in lines if ' W ' not in line and ' w ' not in
line]
Review Comment:
also here? is there a better way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
