kou commented on code in PR #40520:
URL: https://github.com/apache/arrow/pull/40520#discussion_r1532210034
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +64,57 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _just_symbols(self, symbol_info):
+ return [line.split(' ')[-1] for line in symbol_info if line]
Review Comment:
How about parsing `nm` result before calling these filters something like
the following?
```python
result = _nm.run(...)
lines = result.stdout.decode('utf-8').splitlines()
symbol_infos = map(lambda line: re.sub(r'^[\da-fA-F ]+', '', line).split('
', 1), lines)
symbol_infos = self._remove_weak_symbols(symbol_infos)
symbols = self._extract_symbols(symbol_infos)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
