kou commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1533273515
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,36 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ echo "Skip Install - versions are the same"
+ else
+ # the following logic only verifies released versions
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sort --version-sort | head -n1)
+ if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" &&
"$SYSTEM_MAVEN_VERSION" != "$MAVEN_VERSION" ]]; then
Review Comment:
Could you remove redundant condition?
```suggestion
if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" ]]; then
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -1202,6 +1233,7 @@ test_wheels() {
test_jars() {
show_header "Testing Java JNI jars"
+ maybe_setup_maven
Review Comment:
Could you add an empty line between `show_header` and `maybe_setup_*` like
others?
```suggestion
maybe_setup_maven
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,36 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ echo "Skip Install - versions are the same"
+ else
+ # the following logic only verifies released versions
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sort --version-sort | head -n1)
+ if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" &&
"$SYSTEM_MAVEN_VERSION" != "$MAVEN_VERSION" ]]; then
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
+
APACHE_MIRROR="https://www.apache.org/dyn/closer.lua?action=download&filename=";
+ curl -sL -o apache-maven-${MAVEN_VERSION}-bin.tar.gz \
+
${APACHE_MIRROR}/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ tar xzf apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ export PATH=$(pwd)/apache-maven-${MAVEN_VERSION}/bin:$PATH
+ show_info "Installed Maven version $(mvn -v)"
Review Comment:
```suggestion
show_info "Installed Maven version $(mvn -v | head -n 1 | awk
'{print $3}')"
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,36 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ echo "Skip Install - versions are the same"
+ else
+ # the following logic only verifies released versions
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sort --version-sort | head -n1)
+ if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" &&
"$SYSTEM_MAVEN_VERSION" != "$MAVEN_VERSION" ]]; then
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
+
APACHE_MIRROR="https://www.apache.org/dyn/closer.lua?action=download&filename=";
+ curl -sL -o apache-maven-${MAVEN_VERSION}-bin.tar.gz \
+
${APACHE_MIRROR}/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ tar xzf apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ export PATH=$(pwd)/apache-maven-${MAVEN_VERSION}/bin:$PATH
+ show_info "Installed Maven version $(mvn -v)"
+ else
+ show_info "System Maven version ${SYSTEM_MAVEN_VERSION} is equal or
newer than asked Maven version ${MAVEN_VERSION}. Skipping installation."
+ fi
Review Comment:
Could you use 2-space indent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
