ianmcook commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1534044870
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,36 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ echo "Skip Install - versions are the same"
+ else
+ # the following logic only verifies released versions
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sort --version-sort | head -n1)
Review Comment:
This solves the problem of properly sorting unreleased versions, as
described [here](https://unix.stackexchange.com/a/687267):
```suggestion
older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sed 's/$/|/' | sort -V | sed 's/|$//' | head -n1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
