alamb commented on issue #9637:
URL: 
https://github.com/apache/arrow-datafusion/issues/9637#issuecomment-2011805443

   > There is one issue that we are not able to call Arc::into_inner for 
skip-failed-rules path since we hold a clone for restoration.
   
   What I did in https://github.com/apache/arrow-datafusion/pull/9708 which 
seems to have worked pretty well is to copy the LogicalPlan *only* if 
`skip_failed_rules` is set
   
   Like 
[this](https://github.com/apache/arrow-datafusion/pull/9708/files#diff-42d66905c3fa6b245c3493fb4df4816e0fde3036941315ab42198fb16f3907dfR319)
   
   ```rust
                   let prev_plan = if options.optimizer.skip_failed_rules {
                       Some(new_plan.clone())
                   } else {
                       None
                   };
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to