pitrou commented on PR #40699: URL: https://github.com/apache/arrow/pull/40699#issuecomment-2012509142
> @pitrou I would appreciate a preliminary review to check if this is going in the right direction Yes, this is looking ok, though the implementation can be simplified a bit. > For now I didn't go for a dual public / `Impl` class structure like we do for other registries, because it seems that the class itself doesn't need to be public in this case. Just the register / get function should be sufficient for users? Agreed. No need to expose the registry class itself for now. > And I added it to device.h/cc right now, but actually if this will only be used for the C Device interface, could also move it to bridge.h/cc Since the API is minimal and doesn't require any addition includes, we can keep it in `device.h` IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
