pitrou commented on code in PR #40699:
URL: https://github.com/apache/arrow/pull/40699#discussion_r1537887343
##########
cpp/src/arrow/gpu/cuda_memory.cc:
##########
@@ -501,5 +502,27 @@ Result<std::shared_ptr<MemoryManager>>
DefaultMemoryMapper(ArrowDeviceType devic
}
}
+Result<std::shared_ptr<MemoryManager>> DefaultGPUMemoryMapper(int64_t
device_id) {
Review Comment:
Two things:
1. Put it in the anonymous namespace to avoid exposing it
2. Also, rename it to `DefaultCudaMemoryMapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
