Omega359 opened a new pull request, #9730:
URL: https://github.com/apache/arrow-datafusion/pull/9730
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #9703
## Rationale for this change
Function migration.
## What changes are included in this PR?
Code and tests.
## Are these changes tested?
Yes.
## Are there any user-facing changes?
Yes. The dataframe api now requires a vec![] parameter for all trim
functions vs before where it seemed to be mixed between vec and not.
There was a mismatch between the sql interface, the dataframe api and the
documentation around these functions. As you can see in the expr.slt file all
the trim functions could be provided with a second argument which would be the
string to use when trimming. However, the documentation and the dataframe api
only seems to have that for btrim, not the other two functions.
This PR aligns the documentation and the dataframe with the sql so that all
accept a second (optional) argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
