Omega359 commented on code in PR #9730:
URL: https://github.com/apache/arrow-datafusion/pull/9730#discussion_r1535772504
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -752,70 +725,6 @@ mod tests {
Int32Array
);
test_function!(BitLength, &[lit("")], Ok(Some(0)), i32, Int32,
Int32Array);
- test_function!(
Review Comment:
I'm actually migrating that test_function for another PR (#9702) so I think
what I'd like to do is to have a followup PR after that lands to readd those
tests into the code. I'm not a fan of relying strictly on the sql tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]