kou commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1534600591
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,35 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ show_info "System Maven version ${SYSTEM_MAVEN_VERSION} matches required
Maven version ${MAVEN_VERSION}. Skipping installation."
Review Comment:
```suggestion
show_info "System Maven version ${SYSTEM_MAVEN_VERSION} matches required
Maven version ${MAVEN_VERSION}. Skipping installation."
```
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,35 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ show_info "System Maven version ${SYSTEM_MAVEN_VERSION} matches required
Maven version ${MAVEN_VERSION}. Skipping installation."
+ else
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sed 's/$/|/' | sort -V | sed 's/|$//' | head -n1)
+ if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ show_info "Installing Maven version ${MAVEN_VERSION}..."
+
APACHE_MIRROR="https://www.apache.org/dyn/closer.lua?action=download&filename=";
+ curl -sL -o apache-maven-${MAVEN_VERSION}-bin.tar.gz \
+
${APACHE_MIRROR}/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ tar xzf apache-maven-${MAVEN_VERSION}-bin.tar.gz
+ export PATH=$(pwd)/apache-maven-${MAVEN_VERSION}/bin:$PATH
+ show_info "Installed Maven version $(mvn -v | head -n 1 | awk '{print
$3}')"
+ else
+ show_info "System Maven version ${SYSTEM_MAVEN_VERSION} is newer than
minimum version ${MAVEN_VERSION}. Skipping installation."
+ fi
Review Comment:
```suggestion
older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sed 's/$/|/' | sort -V | sed 's/|$//' | head -n1)
if [[ "$older_version" == "$SYSTEM_MAVEN_VERSION" ]]; then
show_info "Installing Maven version ${MAVEN_VERSION}..."
APACHE_MIRROR="https://www.apache.org/dyn/closer.lua?action=download&filename=";
curl -sL -o apache-maven-${MAVEN_VERSION}-bin.tar.gz \
${APACHE_MIRROR}/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz
tar xzf apache-maven-${MAVEN_VERSION}-bin.tar.gz
export PATH=$(pwd)/apache-maven-${MAVEN_VERSION}/bin:$PATH
show_info "Installed Maven version $(mvn -v | head -n 1 | awk '{print
$3}')"
else
show_info "System Maven version ${SYSTEM_MAVEN_VERSION} is newer than
minimum version ${MAVEN_VERSION}. Skipping installation."
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
