kou commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1534620157
##########
dev/release/verify-release-candidate.sh:
##########
@@ -499,6 +499,36 @@ maybe_setup_conda() {
fi
}
+install_maven() {
+ MAVEN_VERSION=3.8.7
+ SYSTEM_MAVEN_VERSION=$(mvn -v | head -n 1 | awk '{print $3}')
+
+ if [[ "$MAVEN_VERSION" == "$SYSTEM_MAVEN_VERSION" ]]; then
+ echo "Skip Install - versions are the same"
+ else
+ # the following logic only verifies released versions
+ older_version=$(printf '%s\n%s\n' "$SYSTEM_MAVEN_VERSION"
"$MAVEN_VERSION" | sort --version-sort | head -n1)
Review Comment:
Hmm. Do we need to add support for unreleased versions?
(I think that we don't need it for easy to maintain with simpler
implementation.)
If we want to support unreleased versions by this approach, could you add a
comment why we need to append `|` only while sorting?
(I don't want to use `|` here because it's one of special characters in
extended regular expressions.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
