vojtechtoman opened a new pull request, #5542: URL: https://github.com/apache/arrow-rs/pull/5542
# Which issue does this PR close? It is related to the optimization work done in the scope of https://github.com/apache/arrow-datafusion/issues/9090. # Rationale for this change While investigating https://github.com/apache/arrow-datafusion/issues/9090 and profiling the bottlenecks in the `to_timestamp` implementation, it turned out that there was potential for improvements in the underlying `string_to_datetime` function. # What changes are included in this PR? * `TimestampParser: eliminate unnecessary calls to `wrapping_sub` * `string_to_datetime`: introduce a constant instead of the expensive call `NaiveTime::from_hms(0, 0, 0)` * timezone `parse_fixed_offset`: reorganize the code to save some unnecessary computation The `parse_timestamp` benchmarks show an improvement in the range of 5-10% (on my machine) in some of the cases. # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
