tustvold commented on code in PR #5542:
URL: https://github.com/apache/arrow-rs/pull/5542#discussion_r1536584985
##########
arrow-array/src/timezone.rs:
##########
@@ -25,27 +25,43 @@ pub use private::{Tz, TzOffset};
fn parse_fixed_offset(tz: &str) -> Option<FixedOffset> {
Review Comment:
My benchmarks are not showing this code as being made any faster (or
slower), but I think the legibility is diminished
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
