advancedxy commented on code in PR #226:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/226#discussion_r1535727760
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -422,15 +421,16 @@ mod tests {
Some(0.0),
Some(-0.0),
Some(-1.0),
+ None,
Review Comment:
Emm, you mean why None is added?
Previously, the murmur3_hash doesn't work correctly due to the issue
https://github.com/apache/arrow-datafusion-comet/pull/226#discussion_r1535126358.
So I added None to demonstrate the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
