advancedxy commented on code in PR #226:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/226#discussion_r1535741537
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1350,7 +1350,7 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
scalarExprToProto("lower", childExpr)
case Md5(child) =>
- val childExpr = exprToProtoInternal(Cast(child, StringType), inputs)
+ val childExpr = exprToProtoInternal(child, inputs)
Review Comment:
I don't think we need to add a cast here? As Spark will perform the cast to
Binary type and DataFusion supports both utf8 and binary input now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
