yyy1000 commented on code in PR #9743:
URL: https://github.com/apache/arrow-datafusion/pull/9743#discussion_r1536298725
##########
docs/source/user-guide/sql/scalar_functions.md:
##########
@@ -3329,18 +3330,55 @@ select * from t;
| 3 | 4 |
+---+---+
-select struct(a, b) from t;
-+-----------------+
-| struct(t.a,t.b) |
-+-----------------+
-| {c0: 1, c1: 2} |
-| {c0: 3, c1: 4} |
-+-----------------+
+select struct(a as field_a, b) from t;
++--------------------------------------------------+
+| named_struct(Utf8("field_a"),t.a,Utf8("c1"),t.b) |
++--------------------------------------------------+
+| {field_a: 1, c1: 2} |
+| {field_a: 3, c1: 4} |
++--------------------------------------------------+
Review Comment:
Got it, thanks! :)
I think it would be better to add a new test case to illustrate this new
feature rather than changing the old one? Just my two cents, let's see what
others would think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
