yyy1000 commented on code in PR #9743:
URL: https://github.com/apache/arrow-datafusion/pull/9743#discussion_r1536859598
##########
datafusion/sqllogictest/test_files/struct.slt:
##########
@@ -63,10 +69,10 @@ query TT
explain select struct(a, b, c) from values;
----
logical_plan
-Projection: struct(values.a, values.b, values.c)
+Projection: named_struct(Utf8("c0"), values.a, Utf8("c1"), values.b,
Utf8("c2"), values.c)
--TableScan: values projection=[a, b, c]
physical_plan
-ProjectionExec: expr=[struct(a@0, b@1, c@2) as
struct(values.a,values.b,values.c)]
+ProjectionExec: expr=[named_struct(c0, a@0, c1, b@1, c2, c@2) as
named_struct(Utf8("c0"),values.a,Utf8("c1"),values.b,Utf8("c2"),values.c)]
--MemoryExec: partitions=1, partition_sizes=[1]
statement ok
Review Comment:
Yes, also a basic test case like the document you added.
`select named_struct('field_a', a, 'field_b', b) from t;`
Edit: or maybe you can add the test cases to a new test file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
