dioptre commented on PR #40729: URL: https://github.com/apache/arrow/pull/40729#issuecomment-2016371134
I took the literal definition bignum to number? On Fri, Mar 22, 2024 at 21:14 Dominik Moritz ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In js/src/util/bn.ts > <https://github.com/apache/arrow/pull/40729#discussion_r1536556864>: > > > } > - return number; > + return Number(number); > > Isn't this incorrect when we have larger numbers? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/40729#pullrequestreview-1956298728>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFZTGGRD74D7ATOE5L72U3YZT6QVAVCNFSM6AAAAABFCPNKICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWGI4TQNZSHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
