dioptre commented on PR #40729: URL: https://github.com/apache/arrow/pull/40729#issuecomment-2017155143
Because the CI tool expects all transformations to be reversible and converting from a decimal to a number is a one way operation - so I had to comment it out. On Sun, Mar 24, 2024 at 06:34 Dominik Moritz ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > ------------------------------ > > In js/test/unit/bn-tests.ts > <https://github.com/apache/arrow/pull/40729#discussion_r1536817745>: > > > + // const n6 = new BN(new Uint32Array([0x00000000, 0x00000000, 0x00000000, 0x80000000]), false); > + // expect(n6.valueOf(1)).toBe(1.7014118346046923e+37); > > Why is this commented out? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/40729#pullrequestreview-1956554607>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFZTGFHVMSFXAVZMXMYUYLYZ3I6TAVCNFSM6AAAAABFCPNKICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWGU2TINRQG4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
